Re: [patch] video: fix SOC_CAMERA_MT9M001 build bug

[Guennadi Liakhovetski]

On Mon, 28 Apr 2008, Ingo Molnar wrote:

> 
> * Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote:
> 
> > > as you can see it from the build log above, the compiler disagrees 
> > > with you on whether the driver depends on I2C. I'm just the 
> > > messenger :)
> > 
> > Very sorry, but I don't see it. What I see above, is that mt9m001 and 
> > mt9v022 cannot be compiled - as I said, _they_ need i2c. And I don't 
> > see a single line for soc_camera.c. SOC_CAMERA is a generic API, it 
> > shouldn't have any hardware dependencies at all. Whereas mt9v022 and 
> > mt9m001 are 2 specific i2c cameras.
> 
> sorry, you are right. Mind doing the right patch as you know this code 
> much better than i do?

Ok, will do, although, the fix is just to duplicate your patch and move it 
from under SOC_CAMERA to MT9V022 and MT9M001. Thanks for reporting.

Guennadi
---
Guennadi Liakhovetski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/