Re: [patch] video: fix SOC_CAMERA_MT9M001 build bug

[Guennadi Liakhovetski]

On Mon, 28 Apr 2008, Ingo Molnar wrote:

> 
> on latest -git, with this config:
> 
>   http://redhat.com/~mingo/misc/config-Mon_Apr_28_13_25_34_CEST_2008.bad
> 
>   CONFIG_SOC_CAMERA_MT9M001=y
>   CONFIG_SOC_CAMERA_MT9V022=y
>   # CONFIG_I2C is not set
> 
> the build fails:
> 
> drivers/built-in.o: In function `reg_read':
> mt9m001.c:(.text+0x140a87): undefined reference to `i2c_smbus_read_word_data'
> drivers/built-in.o: In function `reg_write':
> mt9m001.c:(.text+0x140b6e): undefined reference to `i2c_smbus_write_word_data'
> drivers/built-in.o: In function `reg_read':
> mt9v022.c:(.text+0x1413a7): undefined reference to `i2c_smbus_read_word_data'
> drivers/built-in.o: In function `reg_write':
> mt9v022.c:(.text+0x1414ce): undefined reference to `i2c_smbus_write_word_data'
> drivers/built-in.o: In function `mt9m001_mod_init':
> mt9m001.c:(.init.text+0x158a8): undefined reference to `i2c_register_driver'
> drivers/built-in.o: In function `mt9v022_mod_init':
> mt9v022.c:(.init.text+0x158b8): undefined reference to `i2c_register_driver'
> drivers/built-in.o: In function `mt9m001_mod_exit':
> mt9m001.c:(.exit.text+0x1656): undefined reference to `i2c_del_driver'
> drivers/built-in.o: In function `mt9v022_mod_exit':
> mt9v022.c:(.exit.text+0x1666): undefined reference to `i2c_del_driver'
> 
> adding the missing I2C dependency fixes it.
> 
> Signed-off-by: Ingo Molnar <mingo@xxxxxxx>

NAK. SOC-CAMERA doesn't depend on I2C. It is also suitable for cameras, 
not using i2c. mt9m001 and mt9v022 do both depend on i2c.

> ---
>  drivers/media/video/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: linux/drivers/media/video/Kconfig
> ===================================================================
> --- linux.orig/drivers/media/video/Kconfig
> +++ linux/drivers/media/video/Kconfig
> @@ -850,6 +850,7 @@ endif # V4L_USB_DRIVERS
>  config SOC_CAMERA
>  	tristate "SoC camera support"
>  	depends on VIDEO_V4L2
> +	depends on I2C
>  	select VIDEOBUF_DMA_SG
>  	help
>  	  SoC Camera is a common API to several cameras, not connecting
> 

Thanks
Guennadi
---
Guennadi Liakhovetski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/