Re: [PATCH] Fix calculus of bitmap_scnprintf_len()

From: Mike Travis
Date: Mon Apr 28 2008 - 13:09:30 EST


Paul Jackson wrote:
> Bert wrote:
>> The function bitmap_scnprintf_len() is currently not used
>
> Paul Jackson wrote:
>> How about we just remove that function?
>
> WANG Cong wrote:
>> I am afraid no. See:
>>
>> include/linux/cpumask.h:292: return bitmap_scnprintf_len(len);
>
> Good point.
>
>
> Then how about we also remove from cpumask.h:
>
> #define cpumask_scnprintf_len(len) \
> __cpumask_scnprintf_len((len))
> static inline int __cpumask_scnprintf_len(int len)
> {
> return bitmap_scnprintf_len(len);
> }
>

That's fine with me. A later version of the patch did have
the function removed but it didn't get picked up. The other
changes there were to use function pointers instead of the
flag variable to select list or mask output format, and the
addition of mask variants for the cpu/{present,possible,
online,system} map outputs.

I'll dig that one back up and resubmit it.

Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/