Re: [PATCH 6/19] UML - hppfs fixes

[Jeff Dike]

On Sat, Apr 26, 2008 at 04:31:32PM +0800, WANG Cong wrote:
> > +		rem = copy_to_user(buf, &data->contents[off], count);
> > +		*ppos += count - rem;
> > +		if (rem > 0)
> > +			return -EFAULT;
> 
> Could you please explain why check 'rem' after using it here?

Actually, this isn't as wrong as it looks. copy_to_user returns what
hasn't been copied (rem == remaining).  So, I think the mistake is to
return -EFAULT here.  Returning the short count would be right, unless
rem == count, in which case we return -EFAULT.

       	      	 Jeff

-- 
Work email - jdike at linux dot intel dot com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/