Re: [PATCH] x86: vget_cycles() __always_inline

From: Ingo Molnar
Date: Mon Apr 28 2008 - 11:24:48 EST



* Hugh Dickins <hugh@xxxxxxxxxxx> wrote:

> Mark vget_cycles() as __always_inline, so gcc is never tempted to make
> the vsyscall vread_tsc() dive into kernel text, with resulting
> SIGSEGV.
>
> This was a self-inflicted wound: I've not seen that happen with
> unhacked sources; but for debug reasons I'd changed my x86/Makefile to
> compile no-unit-at-a-time, and that in conjunction with
> OPTIMIZE_INLINING=y ended up with vget_cycles() in kernel text.
> Perhaps it can happen in other ways: safer to use __always_inline.

applied, thanks Hugh - i agree that this is worth fixing.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/