Re: [PATCH 1/4] build: fix missing x86-specific help output

From: Andres Salomon
Date: Mon Apr 28 2008 - 11:16:21 EST


Note that this one is a general x86 fix, I probably should've separated it
out from the other three.

On Fri, 25 Apr 2008 22:34:58 -0400
Andres Salomon <dilinger@xxxxxxxxxx> wrote:

>
> Normally 'make help' spits out architecture-specific targets (including
> things like foo_defconfig). However, it looks like ARCH was never changed
> to SRCARCH during the x86 transition; the makefile still looks in
> arch/i386/configs for arch-specific config files (if ARCH is i386, that is).
>
> This changes it to use SRCARCH, which makes it properly display things
> like i386_defconfig and x86_64_defconfig.
>
> Signed-off-by: Andres Salomon <dilinger@xxxxxxxxxx>
> ---
> Makefile | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 3dbc826..e77149e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1170,7 +1170,7 @@ rpm: include/config/kernel.release FORCE
> # Brief documentation of the typical targets used
> # ---------------------------------------------------------------------------
>
> -boards := $(wildcard $(srctree)/arch/$(ARCH)/configs/*_defconfig)
> +boards := $(wildcard $(srctree)/arch/$(SRCARCH)/configs/*_defconfig)
> boards := $(notdir $(boards))
>
> help:
> @@ -1217,9 +1217,9 @@ help:
> @echo 'Documentation targets:'
> @$(MAKE) -f $(srctree)/Documentation/DocBook/Makefile dochelp
> @echo ''
> - @echo 'Architecture specific targets ($(ARCH)):'
> + @echo 'Architecture specific targets ($(SRCARCH)):'
> @$(if $(archhelp),$(archhelp),\
> - echo ' No architecture specific help defined for $(ARCH)')
> + echo ' No architecture specific help defined for $(SRCARCH)')
> @echo ''
> @$(if $(boards), \
> $(foreach b, $(boards), \
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/