Re: [kvm-ia64-devel] [PATCH] ia64 kvm fixes for O=... builds

From: Al Viro
Date: Mon Apr 28 2008 - 10:14:28 EST


On Mon, Apr 28, 2008 at 09:46:44PM +0800, Zhang, Xiantao wrote:
> > kvm-intel-objs = vmm.o vmm_ivt.o trampoline.o vcpu.o optvfault.o
> > mmio.o \ vtlb.o process.o
> > #Add link memcpy and memset to avoid possible structure assignment
> > error -kvm-intel-objs += memset.o memcpy.o
> > +kvm-intel-objs += ../lib/memset.o ../lib/memcpy.o
> > obj-$(CONFIG_KVM_INTEL) += kvm-intel.o
>
> I don't think it is workable for kvm-ia64. Currently, kvm-intel module
> needs to be relocated at insertion time, so the code is
> position-indenpent. Howerver, lib/*.memset.o(memcoy.o) are not compiled
> as position independent code, they can't be linked into the module
> correctly in your way. That is why we use symbol link instead of linking
> the objects under /lib.

symlinks won't work as you use them. If you really need separately
compiled, use file with a couple of #include "../lib/......S" and
be done with that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/