Re: [PATCH] x86: mtrr cleanup for converting continuous to discretelayout v2

[Arjan van de Ven]

On Mon, 28 Apr 2008 15:08:26 +0200
Ingo Molnar <mingo@xxxxxxx> wrote:

> 
> * Yinghai Lu <yhlu.kernel.send@xxxxxxxxx> wrote:
> 
> > some BIOS like to use continus MTRR layout, and X driver can not
> > add WB entries for graphical cards when 4g or more RAM installed.
> > 
> > the patch will change MTRR to discrete.
> > 
> > mtrr_chunk_size= could be used to have smaller continuous block to 
> > hold holes. default is 256m, could be set according to size of 
> > graphics card memory.
> 
> hm.
> 
> > +static int disable_mtrr_cleanup;
> 
> i think this should be default-disabled. Touching MTRRs on a live
> system could interact with SMM and MCE handlers.

yep one should not touch existing MTRRs. If you run out, tough luck.
Thats what we have PAT for.
Changing them anyway is a deathtrap with various things, suspend/resume being only
one of the nasty cases.

> 
> how relevant is this feature with modern Xorg? I thought modern Xorg 
> would get its mappings via /sys, hence it would not have to touch
> MTRRs at all.

that's true for current X, but not for 6 month old X :=(

-- 
If you want to reach me at my work email, use arjan@xxxxxxxxxxxxxxx
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/