Re: [PATCH] sched: missing locking in sched_domains code

From: Ingo Molnar
Date: Mon Apr 28 2008 - 09:14:30 EST



* Heiko Carstens <heiko.carstens@xxxxxxxxxx> wrote:

> > version 42. Please feel free to change the comment if you think it could
> > be better :)
>
> I don't believe this... version 43 ;) I forgot to add the lock in
> sched_init_smp(). Not that it would really matter, but it should be
> there to avoid (even more) confusion.

hey i just had to iterate it to version 44.

this bit:

> -/* doms_cur_mutex serializes access to doms_cur[] array */
> -static DEFINE_MUTEX(doms_cur_mutex);
> +/* sched_domains_mutex serializes calls to arch_init_sched_domains,
> + * detach_destroy_domains and partition_sched_domains.
> + */
> +static DEFINE_MUTEX(sched_domains_mutex);

was inside an #ifdef section ;-)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/