Re: [PATCH] iwlwifi: Fix build error in v2.6.25-5561-g064922a

[Carlos R. Mafra]

On Sun 27.Apr'08 at 23:35:07 -0700, David Miller wrote:
> From: "Carlos R. Mafra" <crmafra2@xxxxxxxxx>
> Date: Mon, 28 Apr 2008 02:47:01 -0300
> 
> > I've just tried to compile v2.6.25-5561-g064922a and it failed with
> > these messages:
> 
> Already fixed in net-2.6 by:
> 
> commit bd8fd21dfddf51299d782f598cb776b15b7d64cc
> Author: Luca Tettamanti <kronos.it@xxxxxxxxx>
> Date:   Sun Apr 27 15:34:55 2008 -0700
> 
>     wireless: Fix compile error with wifi & leds
>     
>     Fix build error caused by commit
>     e82404ad612ebabc65d15c3d59b971cb35c3ff36 ("iwlwifi: Select
>     LEDS_CLASS.") from David Miller:
>     
>     Since MAC80211_LEDS is selected by wireless drivers it must select its
>     own dependencies otherwise a build error may occur (kbuild will select
>     the symbol regardless of "depends" constraints).
>     
>     Signed-off-By: Luca Tettamanti <kronos.it@xxxxxxxxx>
>     Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> 
> diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
> index 520a518..a24b459 100644
> --- a/net/mac80211/Kconfig
> +++ b/net/mac80211/Kconfig
> @@ -73,7 +73,9 @@ config MAC80211_MESH
>  
>  config MAC80211_LEDS
>  	bool "Enable LED triggers"
> -	depends on MAC80211 && LEDS_TRIGGERS
> +	depends on MAC80211
> +	select NEW_LEDS
> +	select LEDS_TRIGGERS
>  	---help---
>  	  This option enables a few LED triggers for different
>  	  packet receive/transmit events.

Hmm, I just tested this patch and it does not solve the problem. 

I could create a .config using 'make menuconfig' in which I had

CONFIG_MAC80211_LEDS=y
CONFIG_RFKILL_LEDS=y
CONFIG_IWLWIFI_LEDS=y
CONFIG_IWL4965_LEDS=y
CONFIG_NEW_LEDS=y
CONFIG_LEDS_CLASS=m

So I recompiled the kernel and got the same error message as before.

What my patch does is to make a .config with CONFIG_LEDS_CLASS=m and 
CONFIG_IWL4965_LEDS=y be impossible to exist, because it
appears that this combination is what causes the build error.

But anyways, I've just read about the Kconfig language a few hours
ago when I had this problem and tried to solve it, so my patch is
probably missing something. But it works for me in the sense that
IWL4965_LEDS doesn't even show as an option in 'make menuconfig' 
if LEDS_CLASS=m, so I user like me can not generate a .config which 
does not build correctly.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/