Re: [RFC PATCH 26/26] UBIFS: include FS to compilation

From: Adrian Hunter
Date: Mon Apr 28 2008 - 03:14:24 EST


ext Christoph Hellwig wrote:
On Tue, Apr 01, 2008 at 11:51:50AM +0300, Artem Bityutskiy wrote:
But these don't make much sense to me. Why would you want to be able
to compile out printks at this granularity? Why not enable all of them
when CONFIG_UBIFS_FS_DEBUG is enabled?
Well, its just more convenient for us. If I know the bug is somewhere in
the journal, I enable the journal messages - less flooding. We may
lessen the amount, but it is still handy to have some classes of
prints separate.

It's everything but convenient :) Please make it one config option to
compile in all debug code and then have a module option to select the
verbosity level at runtime.

Surely that judgement should be made by people who actually debug UBIFS.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/