Re: [RFC Patch 1/1] debugfs_printk and debugfs_dump interface

[Michael Ellerman]

On Mon, 2008-04-28 at 10:18 +0530, K. Prasad wrote:
> On Mon, Apr 28, 2008 at 10:50:51AM +1000, Michael Ellerman wrote:
> > On Fri, 2008-04-25 at 13:49 +0530, K. Prasad wrote:
> > > On Fri, Apr 25, 2008 at 01:12:00PM +0530, K. Prasad wrote:
> > > > Please find the new patch below.
> > > > > 
> > > Let the email slip through a little early. Please find the revised
> > > patch below.
> > > 
> > > Thanks,
> > > K.Prasad
> > > 
> > > This patch introduces two new interfaces called debugfs_printk and 
> > > debugfs_dump which can be used to print to the debugfs mount directly.
> > > It uses the 'trace' infrastructure underneath and is a patch over it.
> > > A sample file is also created to demonstrate its ease of use.
> > 
> > I still think debugfs_printk() is not the right name, as it is not part
> > of the existing family of debugfs_* routines.

> Whether to call it trace_printk() and trace_dump() is a suggestion I
> would like to ask David Wilder (and others). Let me know if you think
> there are better names.

That would be my pick, given that it's using the trace infrastructure
and it's defined in trace.h, implemented in trace.c, and documented in
trace.txt :)

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

Attachment: signature.asc
Description: This is a digitally signed message part