Re: [PATCH] xfs: reduce stack usage in xfs_page_state_convert()

From: Christoph Hellwig
Date: Sun Apr 27 2008 - 23:50:52 EST


On Mon, Apr 28, 2008 at 09:23:17AM +1000, David Chinner wrote:
> No. That code is complex enough with only one copy of it around. I don't
> want two copies that differ subtly and hence have two different sets
> of nasty, rarely hit corner cases in them.

Actually the split makes some sense. I had a ready patch to split out
releasepage which makes the whole code a lot nicer. I didn't go forward
with it because I had this idea that it would get replaced by Chris
extent_map stuff ASAP..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/