Re: [patch] x86, voyager: fix ioremap_nocache()

[Al Viro]

On Sun, Apr 27, 2008 at 08:31:27PM -0400, Rik van Riel wrote:
> On Sun, 27 Apr 2008 16:31:06 -0700 (PDT)
> David Miller <davem@xxxxxxxxxxxxx> wrote:
> 
> > You can post whatever patches you like a million times to lkml.
> > That's not the problem.
> > 
> > It's that the patches don't get reviewed, posting them more or to a
> > different place doesn't help that.
> 
> If you really want to enforce this, I bet it could be automated
> with scripts around git.
> 
> Simply refuse to apply a patch that does not have at least two
> Signed-off-by/Reviewed-by/Acked-by lines and refuse to apply
> a "git pull" if there is a changeset like that in the tree.

Yeah, right.
commit 138fe4e069798d9aa948a5402ff15e58f483ee4e
Author: Konrad Rzeszutek <ketuzsezr@xxxxxxxxxx>
Date:   Wed Apr 9 19:50:41 2008 -0700

    Firmware: add iSCSI iBFT Support
...
    [akpm@xxxxxxxxxxxxxxxxxxxx: fix build]
    Signed-off-by: Konrad Rzeszutek <konradr@xxxxxxxxxxxxxxxxxx>
    Cc: Mike Christie <michaelc@xxxxxxxxxxx>
    Cc: Peter Jones <pjones@xxxxxxxxxx>
    Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
    Cc: Ingo Molnar <mingo@xxxxxxx>
    Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
    Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
    Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
...
+static ssize_t sprintf_ipaddr(char *buf, u8 *ip)
+{
...
+               str += sprintf(str, NIP6_FMT, ntohs(ip[0]), ntohs(ip[1]),
+                              ntohs(ip[2]), ntohs(ip[3]), ntohs(ip[4]),
+                              ntohs(ip[5]), ntohs(ip[6]), ntohs(ip[7]));

are you going to tell me that this had been reviewed?  Note these
ntohs() applied to 8bit values in there.  Two signed-off-by, including
Greg "two s-o-b are enough to guarantee review"...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/