Re: find_new_bit bloat from x86 tree...

[Ingo Molnar]

* David Miller <davem@xxxxxxxxxxxxx> wrote:

> Ingo, what the heck is this?
> 
> commit 64970b68d2b3ed32b964b0b30b1b98518fde388e
> Author: Alexander van Heukelum <heukelum@xxxxxxxxxxxxx>

(Alexander Cc:-ed.)

> Date:   Tue Mar 11 16:17:19 2008 +0100
> 
>     x86, generic: optimize find_next_(zero_)bit for small constant-size bitmaps
> 
> Thanks for bloating up the inline expansion of this thing on every 
> architecture that doesn't do __ffs() in a simple sequence of a few 
> instructions like x86 does.

ok, that's bad. How much is the before/after vmlinux btw, i guess you 
measured it? We could either make it per arch selectable, or we could 
just uninline it all. It shouldnt be a big deal on x86 and it should 
help on RISC platforms.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/