Re: [PATCH] PCI Express ASPM support should default to 'No'

[Jesper Juhl]

2008/4/24 Andi Kleen <andi@xxxxxxxxxxxxxx>:
>
> Shaohua Li <shaohua.li@xxxxxxxxx> writes:
>
>  > On Tue, 2008-04-22 at 17:12 -0700, Jesse Barnes wrote:
>  >> On Tuesday, April 22, 2008 3:28 pm Jesper Juhl wrote:
>  >> > Running 'make oldconfig' I just noticed that PCIEASPM defaults to
>  >> > 'y' in Kconfig even though the feature is both experimental and the
>  >> > help text recommends that if you are unsure you say 'n'.
>  >> > It seems to me that this really should default to 'n', not 'y' at the
>  >> > moment.
>  >> > The following patch makes that change. Please consider applying.
>  >>
>  >> Seem reasonable, Shaohua?  Please cc linux-pci on PCI patches
>  >> though...
>  > Ok, I'm fine with the patch. Though by default, the policy is to use
>  > BIOS setting, that is if BIOS disables ASPM, we don't enable it too.
>
>  Once the feature is considered stable it would be nice to make it default y
>  again. I think any power saving should be on by default (unless serious
>  issues are known), not off.
>
I agree, but as long as it's marked EXPERIMENTAL and there's even a
warning in the help text telling users to select 'n' if they are
unsure I think it makes sense to make 'n' the default.
Once it's been tested some more, is no longer experimental, then we
can change it back to 'y' easily.

-- 
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/