Re: [PATCH] fix file and descriptor handling in perfmon

[Robin Holt]

Not really an objection, just a simple comment.

On Sun, Apr 27, 2008 at 02:18:02AM +0100, Al Viro wrote:
...
> -static int
> -pfm_alloc_fd(struct file **cfile)
> +static struct file *pfm_alloc_file(pfm_context_t *ctx)

ZZZ
You mangle the style.  Not sure how important that is to Stephane, et
al.  They appear to use a two line function name which does make
searching with vi easier because /^pfm_alloc_file finds the function.

Thanks,
Robin Holt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/