Re: [PATCH] headerdep: a tool for detecting inclusion cycles inheader file

[Adrian Bunk]

On Sat, Apr 26, 2008 at 06:57:09PM +0200, Vegard Nossum wrote:
> On 4/26/08, Adrian Bunk <bunk@xxxxxxxxxx> wrote:
> > On Sat, Apr 26, 2008 at 03:45:54PM +0200, Vegard Nossum wrote:
> >
> > > Hi Sam,
> >  >
> >  > Maybe something like this could be useful for cleaning up headers (and
> >  > maintaining that cleanliness once it has been achieved). What do you think?
> >
> > >...
> >
> >  And another note (after looking at the Cc list):
> >
> >  Header cleanup is *not* something suitable as a first task for a janitor.
> 
> Hehe, yes, I could not agree more!
> 
> I have been trying to resolve some of these errors myself, but it's
> incredibly hard to get right.
> 
> The reason I CCed kernel-janitors is that this IS a janitorial
> project. But I am not implying that janitor means "newbie" or trivial.
> At least the way I see it, janitor work is cleaning up, but not
> necessarily easy work. But I agree, definitely not a first task job.

kernel-janitors is basically for "I'm new to kernel development and 
want an easy task".

> >  The interesting cases are non-trivial.
> >
> >  And you need cross compilers for all architectures since fiddling with
> >  #include's under include/ breaks code left and right that only compiled
> >  due to some implicit #include (and if it still works due to another
> >  implicit #include on x86 the latter might not be present on all
> >  architectures).
> 
> Yep. I have been compiling cross-compilers myself. As a btw, I had
> already started some project to distribute binary cross-compilers
> http://folk.uio.no/vegardno/crosstool/ for the purpose of making
> cross-compiling easier to get started with. (It would be cool to have
> a complete suite of working cross-compilers in a single download.)

"The source code for the binary files below can be downloaded from the 
 aforementioned project websites."

-> GPL violation

> Vegard

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/