Re: [PATCH 2/3] i2c: Add Intel SCH I2C SMBus support

[Andrew Morton]

> On Wed, 23 Apr 2008 14:32:12 +0200 Jean Delvare <khali@xxxxxxxxxxxx> wrote:
> Hi Alek,
> 
> On Tue, 22 Apr 2008 10:04:20 +0800, alek du wrote:
> > This patch adds Intel SCH chipsets (US15W, US15L, UL11L) i2c bus support.
> 
> What kind of machines are these?
> 
> > 
> > Signed-off-by: Alek Du <alek.du@xxxxxxxxx>
> > ---
> >  drivers/i2c/busses/Kconfig   |    7 +
> >  drivers/i2c/busses/Makefile  |    1 +
> >  drivers/i2c/busses/i2c-sch.c |  419 ++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 427 insertions(+), 0 deletions(-)
> >  create mode 100644 drivers/i2c/busses/i2c-sch.c
> > (...)
> 
> MAINTAINERS says:
> 
> I2C SUBSYSTEM
> (...)
> L:	i2c@xxxxxxxxxxxxxx
> 
> So it would be great if you could send your patch there rather than on
> LKML.
> 

"as well as" would be better than "rather than", please.


I worry about the inclusion of apm_bios.h.  The driver is configured to be
available on all architectures but apm_bios.h is surely x86-specific (and
maybe mips).

But afaict the inclusion is not needed?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/