Re: [REGRESSION] x86: support for new UV apic

From: Priit Laes
Date: Fri Apr 25 2008 - 11:53:20 EST


Ãhel kenal pÃeval, R, 2008-04-25 kell 11:45, kirjutas Andi Kleen:
> Ingo Molnar <mingo@xxxxxxx> writes:
>
> > * Priit Laes <plaes@xxxxxxxxx> wrote:
> >
> >> Hey,
> >>
> >> I am getting two following warnings (probable one per each CPU core)
> >> using the latest Linus's git:
> >>
> >> WARNING: at arch/x86/kernel/genapic_64.c:86 read_apic_id+0x30/0x62()
> >> Modules linked in:
> >> Pid: 1, comm: swapper Not tainted 2.6.25-03563-gf7288b1 #20
> >
> > thanks - could you check the patch below, does it fix the warnings?
>
> I think it would have been better to change the WARN_ON to
>
> WARN_ON(preemptible() && num_online_cpus() > 1)
>
> Preemption is actually ok here because this runs before the other
> CPUs are started
>
> Alternative patch appended.

Worksforme :)

--
Priit Laes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/