Re: [PATCH] m32r: test before subtraction on unsigned relocation range

[Hirokazu Takata]

From: Roel Kluin <12o3l@xxxxxxxxxx>
Subject: [PATCH] m32r: test before subtraction on unsigned relocation range
Date: Wed, 23 Apr 2008 18:34:16 +0200
>  		case R_M32R_26_PCREL_RELA:
> -	  		relocation = (relocation - (Elf32_Addr) location);
> -			if (relocation < -0x2000000 || 0x1fffffc < relocation)
> +			if (relocation + 0x20000 < (Elf32_Addr) location ||
> +					relocation >= 0x1fffc + (Elf32_Addr) location)

A slight fix is required.

The above range check is incorrect, because the R_M32R_26_PCREL_RELA is
26-bit relocation.

-- Takata
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/