Re: [PATCH] alternative^2 to sys_indirect: socket, socketpair

From: David Miller
Date: Thu Apr 24 2008 - 21:41:18 EST


From: Ulrich Drepper <drepper@xxxxxxxxxx>
Date: Thu, 24 Apr 2008 09:37:47 -0700

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Alan Cox wrote:
>
> >> -int sock_map_fd(struct socket *sock)
> >> +static int sock_map_fd_flags(struct socket *sock, int flags)
>
> sock_map_fd is exported to modules. Isn't it a big no-no to change
> those interfaces?

It's perfectly acceptable to change the interface however
you like when necessary, and merely fix up all the in-tree users.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/