Re: [PATCH] Fix VIDIOCGAP corruption in ivtv

[Mauro Carvalho Chehab]

Hi Frank/Alan,

On Thu, 24 Apr 2008 04:26:46 +0900
"Frank Bennett" <biercenator@xxxxxxxxx> wrote:

> Maruo,
> 
> I don't want to make your life more complicated than necessary, but
> while we're on the topic of attribution ...
> 
> The real work in identifying this issue was done by Andrew Macks, the
> engineer at Skype. My role in the affair consisted of complaining,
> sending along a log file, recompiling the kernel, and writing an email
> message.
> 
> I relayed the initial response I received from Hans Verkuil to Andrew
> (via skype chat, I do not have an email address for him), to let him
> know that the problem was being addressed in the kernel, and he was
> glad to hear the news. But watching things unfold, I have been feeling
> slightly incomfortable that only my name might end up in the chain of
> correspondence, and not his.  I would just like to slip in a note here
> to that effect.

Maybe we can just add his name in parenthesis. Would this patch description be
ok for you, Andrew and Alan?

Fix VIDIOCGAP corruption in ivtv

From: Alan Cox <alan@xxxxxxxxxx>

Frank Bennett reported that ivtv was causing skype to crash. With help
from one of their developers (Andrew Macks) he showed it was a kernel problem.
VIDIOCGCAP copies a name into a fixed length buffer - ivtv uses names
that are too long and does not truncate them so corrupts a few bytes of
the app data area.

Possibly the names also want trimming but for now this should fix the
corruption case.

Signed-off-by: Alan Cox <alan@xxxxxxxxxx>
Signed-off-by: Hans Verkuil <hverkuil@xxxxxxxxx>
Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/