Re: [PATCH RFC] x86: Fix 64-bit DMA masks on VIA

From: Michael Buesch
Date: Thu Apr 24 2008 - 10:06:50 EST


On Thursday 24 April 2008 15:43:50 Andi Kleen wrote:
> Michael Buesch <mb@xxxxxxxxx> writes:
>
> > This untested patch is supposed to fix DMAing on some VIA boards.
> > Currently the DMA subsystem returns an error, if the driver does
> > tell that it supports a 64bit DMA mask. So the driver probing
> > would fail in that case.
>
> The driver is broken then. It is supposed to retry with a small
> mask on an error. Please fix the driver.

I already added a workaround to the driver.
Why do we need to workaround this in _every_ driver? (Note that _every_
driver supporting a 64bit mask is affected). Why not fix it in the DMA layer?

--
Greetings Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/