Re: [PATCH] wireless: rndis_wlan: modparam_workaround_interval isnever below 0.

From: John W. Linville
Date: Thu Apr 24 2008 - 08:59:47 EST


On Thu, Apr 24, 2008 at 12:26:28PM +0300, Jussi Kivilinna wrote:
> Quoting Johannes Berg <johannes@xxxxxxxxxxxxxxxx>:
>
>>
>> Eh, why not make the modparam unsigned and default to 500?
>>
>> johannes
>>
>
> Now that I stop and think about it, that would be better option. The
> modparam already has default value of 500.
>
> Reason why workaround modparam is signed, is that value -1 did have some
> functionality in some early version. That then changed and
> priv->param_workaround_interval changed to unsigned and forgot about
> modparam.

I merged the patch, so if you want that behavior we need a new patch.

John
--
John W. Linville
linville@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/