Re: [2.6 patch] remove ata_cable_sata()

[Adrian Bunk]

On Wed, Apr 23, 2008 at 07:22:43PM +0100, Alan Cox wrote:
> On Mon, 21 Apr 2008 11:51:31 +0300
> Adrian Bunk <bunk@xxxxxxxxxx> wrote:
> 
> > This patch removes the no longer used ata_cable_sata()
> > 
> > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx>
> 
> NAK - this one is a sensible part of the driver API

I must have missed something.

I thought that you could simply set .flags in a driver without needing 
any helper for .cable_detect .

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/