Re: [PATCH] wireless: rndis_wlan: modparam_workaround_interval isnever below 0.

From: Johannes Berg
Date: Thu Apr 24 2008 - 04:57:50 EST


On Wed, 2008-04-23 at 22:10 +0200, Roel Kluin wrote:
> priv->param_workaround_interval is unsigned,
> modparam_workaround_interval not.
> the former is never < 0.

> - priv->param_workaround_interval = modparam_workaround_interval;
>
> - if (priv->param_workaround_interval < 0)
> + if (modparam_workaround_interval < 0)
> priv->param_workaround_interval = 500;
> + else
> + priv->param_workaround_interval = modparam_workaround_interval;

Eh, why not make the modparam unsigned and default to 500?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part