Re: [PATCH] x86: vm86 - hide X86_VM_MASK from userland programs

From: Cyrill Gorcunov
Date: Thu Apr 24 2008 - 04:43:37 EST


[David Woodhouse - Thu, Apr 24, 2008 at 09:39:24AM +0100]
| On Thu, 2008-04-24 at 12:35 +0400, Cyrill Gorcunov wrote:
| > X86_VM_MASK is a kernel specific flag so lets hide it from
| > userland programs
| >
| > Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
|
| Since and there's already an #ifdef __KERNEL__ section later on in the
| file, and since X86_VM_MASK isn't used before that, I probably would
| have been inclined to shift it down there instead of adding a new
| #ifdef.
|
| But maybe I should just stop heckling... :)
|
| --
| dwmw2
|

I was thought about that too ;) David, I'll recheck this
all today evening (have to go to office now). And please
continue heckling - it allows to make this file in particular
*better*, so I think it's ok ;)

- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/