Re: [PATCH] xfs: use smaller int param in call to xfs_flush_pages

From: David Chinner
Date: Tue Apr 22 2008 - 18:09:21 EST


On Tue, Apr 22, 2008 at 05:14:45AM +0200, Denys Vlasenko wrote:
> Hi David,
>
> xfs_flush_pages() flags parameter is declared as uint64_t, but
> code never pass values which do not fit into 32 bits.
> All callsites sans one pass zero, and the last one passes
> XFS_B_DELWRI, XFS_B_ASYNC or zero.
> These values are defined in enum xfs_buf_flags_t and they
> all fit in 32 bits.

Can you fold this into the previous patch that kills fiopt to
this function?

Cheers,

Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/