Re: [PATCH sched-devel] ftrace: trace_entries to change tracebuffer size

[Andrew Morton]

On Fri, 18 Apr 2008 08:48:09 -0400 (EDT) Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> > > +		data->lock = (raw_spinlock_t)__RAW_SPIN_LOCK_UNLOCKED;
> > > +		max_tr.data[i]->lock = (raw_spinlock_t)__RAW_SPIN_LOCK_UNLOCKED;
> >
> > eww.  This *really* needs explanatory comments.
> >
> 
> Actually, that's just a way of doing spin_lock_init for raw spin locks. I
> didn't see any other way.

Maybe we need raw_spin_lock_init().  And DEFINE_RAW_SPINLOCK()?

Although it isn't a great idea to be encouraging the use of raw 
spinlocks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/