Re: [PATCH] firewire: fw-ohci: conditionally log busReset interrupts

[Jarod Wilson]

On Monday 07 April 2008 04:33:35 pm Stefan Richter wrote:
> Add a debug option to watch bus reset interrupt events.  Half of this
> patch is taken from Jarod Wilson's first version of the JMicron fix.
> 
> BusReset interrupts are only generated if the respective module
> parameter flag was set before the controller is being initialized.  We
> keep this event masked otherwise to reduce IRQ load in normal operation
> and to avoid potential problems with buggy chips.
> 
> Note, this is unlike the other IRQ events whose logging can be enabled
> any time after chip initialization.  This and the influence on what
> interrupts the chip generates is why I added an extra flag for it.
> 
> Also, reorder the debug parameter flags according to their perceived
> usefulness.
> 
> Signed-off-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>
> ---

Indeed, after discussing, this looks much safer.

Signed-off-by: Jarod Wilson <jwilson@xxxxxxxxxx>


-- 
Jarod Wilson
jwilson@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/