Re: [PATCH] atmel serial reduce trasmitting window & code stylepatch

[Haavard Skinnemoen]

On Thu, 3 Apr 2008 10:39:06 +0200 (CEST)
Michael Trimarchi <trimarchimichael@xxxxxxxx> wrote:

> Reduce the trasmitting window size to avoid blocking of tasklet because 
> it must handle the receive phase too.
> 
> Signed-off-by: michael <trimarchi@xxxxxxxxxxxxxxxx>

Ok, the patch seems to make sense, but your description isn't very good...
  * What problem does this patch solve (I think I know it, but I don't
    want to guess.)
  * This patch doesn't really reduce any "TX window" since the window
    simply didn't exist before (or was infinitely long or whatever.) I
    think you should mention that this limitation is a new thing.
  * Why is 32 a good value?

Also, do we need to reschedule the tasklet if we terminate the loop
because of this limit? I think we can get away with not doing it since
the interrupt handler will be triggered as soon as we enable the TX
interrupt. But perhaps we should avoid enabling the interrupt and
schedule the tasklet since we _know_ there's a TX interrupt pending?

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/