Re: kernel BUG at drivers/block/ub.c:820!

[Kiyoshi Ueda]

Hi Andrew, Greg, Pete,

On Thu, 3 Apr 2008 21:30:10 -0700, Andrew Morton wrote:
> On Thu, 03 Apr 2008 20:36:38 +0300 Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote:
> 
> > On Thu, Apr 03 2008 at 19:30 +0300, Pete Zaitcev <zaitcev@xxxxxxxxxx> wrote:
> > > On Thu, 03 Apr 2008 17:18:31 +0200, Martin Schwidefsky <schwidefsky@xxxxxxxxxx> wrote:
> > >> On Thu, 2008-04-03 at 11:08 -0500, Kiyoshi Ueda wrote:
> > > 
> > >>> I believe the patch from Pete fixes this BUG():
> > >>>     http://marc.info/?l=linux-usb&m=120613888005382&w=2
> > >>>
> > >>> Could you try that?
> > >> Just tested the patch and it indeed fixes the bug.
> > > 
> > > I'm glad.
> > > 
> > >> Could we push this upstream for 2.6.25? It is a regression, I would
> > >> prefer to have a 2.6.25 that doesn't panic my machine when I attach a
> > >> USB stick..
> > > 
> > > I was going to work through Greg as usual and then push it to
> > > the stable tree. I'm not Linus' "leutenant", so I cannot just send
> > > him random patches.
> > > 
> > > -- Pete
> > 
> > This is a block device siting in block/ folder. It is certainly Jens's
> > linux-block territory. Best put it through the tree that introduced the
> > bug, no?
> > 
> > Best would be to resend to Jens ASAP, it is a 2.6.25 regression.
> 
> I stole it out of Greg's tree - I'll merge it Saturdayish unless someone
> stops me.

I think that it is a broken patch and Pete wants you to take
the patch below:
    http://marc.info/?l=linux-usb&m=120613888005382&w=2

The patch, which Greg and Andrew is taking now, was tested by Chris
Wedgwood and he detected a bug is still in there:
    http://marc.info/?l=linux-usb&m=120603584207543&w=2
Pete revised it and posted the new patch as above, but the new patch
seems not to be included in the Greg's tree yet.


Pete,
The new patch you posted seems not having your sign-off.
Could you follow it so that the new patch can be included instead of
the old patch?

Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/