Re: [RFC 18/22] sh: Use generic show_mem()

From: Paul Mundt
Date: Thu Apr 03 2008 - 07:43:45 EST


On Wed, Apr 02, 2008 at 10:40:24PM +0200, Johannes Weiner wrote:
> - printk(KERN_INFO "Total of %ld pages in page table cache\n",
> - quicklist_total_size());
> -}
> -

NACK. The quicklists are also absent from the generic implementation.
Doing things generically is nice and all, but please do not go around
removing all of the different implementations and consolidating on the
simplest point of commonality you could come up with. Either combine
everything in to a generic show_mem() that doesn't sacrifice
functionality, or only convert the platforms that are identical.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/