Re: [PATCH 7/7] asm-generic: suppress sparse warning in ioctl.h

From: Al Viro
Date: Wed Apr 02 2008 - 22:55:58 EST


On Wed, Apr 02, 2008 at 07:51:08PM -0700, Linus Torvalds wrote:
>
>
> On Thu, 3 Apr 2008, Al Viro wrote:
> >
> > Um... But that's _not_ a link-time constant - simply an int variable not
> > defined in any object file...
>
> Ahh, you're right, my bad. We could change it to take the address of it,
> though. I assume gcc is happy with that too?

gcc might be, but what are you going to do with it? Expression is an
integer one, after all - in cases that had triggered that thread it
was used (after & 0xff) as array index.

Besides, logically it's _not_ a constant at all - not even a base + constant,
after using it in such expression...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/