Re: 2.6.25-rc8-mm1 (mips build failure)

[Christoph Lameter]

On Wed, 2 Apr 2008, Andrew Morton wrote:

> i386 generates
> 
> ->NR_PAGEFLAGS $18 __NR_PAGEFLAGS       #

> mips generates
> 
> ->NR_PAGEFLAGS 18 __NR_PAGEFLAGS         #

For some reason the asm-offset.c for mips generates it differently and the 
sed expression in kbuild is different. So it does not match.
 
> The only difference is the "$".  This can be trivially handled in the sed
> expression which filters this .s file.

Maybe the simple solution is to drop the strange mips way of doing things 
and clean up Kbuild in the process?

> Why are we diddling with that "->" thing, and why does it even exist?

I guess this is some convention to allow the Kbuild set script to extract 
the value. There must be some reason that they added the strange prefix.

ccing Sam who may shed some light on this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/