Re: 2.6.25-rc regression: bttv: oops on radio access (bisected)

[Bongani Hlope]

On Tuesday 01 April 2008 22:10:51 Mauro Carvalho Chehab wrote:
> Hi Marcin
>
> On Sun, 30 Mar 2008 18:20:49 +0200
>
> Marcin Slusarz <marcin.slusarz@xxxxxxxxx> wrote:
> > Hi
> > 2.6.25-rc7 kernel oopses on exec of "radio -c /dev/radio0".
> > I bisected it down to:
> >
> > 402aa76aa5e57801b4db5ccf8c7beea9f580bb1b is first bad commit
> > commit 402aa76aa5e57801b4db5ccf8c7beea9f580bb1b
> > Author: Douglas Schilling Landgraf <dougsland@xxxxxxxxx>
> > Date:   Thu Dec 27 22:20:58 2007 -0300
> >
> >     V4L/DVB (6911): Converted bttv to use video_ioctl2
> >
> >     Signed-off-by: Douglas Schilling Landgraf <dougsland@xxxxxxxxx>
> >     Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>
>
> There are three patches that are meant to fix the bugs with radio. On the
> tests I did here, they worked, but the Bongani still points that the fixes
> didn't solve for him.
>

I decoded the oops that I got and found that the cause was the 
miss-application of  Robert Fitzsimons' patch. On the git version that I had, 
the radio_release function was not on the lines on that patch (I just saw 
the .rej file ;)

> On the tests I did here, the three patches seemed to work [1]. Maybe you
> could test with those patches and post us some results.
>

Those patches brings back both the TV and radio functionality, the tv 
functionality loss seem to have been lost when radio_release oopsed and 
didn't decrement btv->radio_user

> There are three patches meant to fix several issues caused by the
> conversion:
>
> http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commitdiff;
>h=bdd38d9b5c6365ea004df6d8a183dd1344b4801f
> http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commitdiff;
>h=055a6282cabd311cf010a5a83f0494558504f7d0

These two above fixed it for me too

> http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commitdiff;
>h=6e07ff78274752fe812a1e8bddb6013a278e62e8
>

I can't comment on this one since I don't use 32bit user-space

> Could you test please and give us some feedback?
>

I confirm that those patches fixed the bttv-driver for me, it was the 
misapplied patch that caused the Oops. Please push to Linus and I'll ask 
Rafael to close the bug as soon as it gets to mainline.

Thanx for all your work Mauro and the V4L developers.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/