Re: [PATCH] Drop an empty byteorder/generic.h from being exportedto userspace.

[Robert P. J. Day]

On Wed, 2 Apr 2008, Jiri Slaby wrote:

> On 04/02/2008 01:00 PM, Robert P. J. Day wrote:
> > On Wed, 2 Apr 2008, Jiri Slaby wrote:
> >
> > > On 04/02/2008 03:38 AM, Robert P. J. Day wrote:
> > > > Since the entire meaningful contents of generic.h is wrapped by the
> > > > __KERNEL__ test, drop it from being passed to userspace, and remove
> > > > the now superfluous __KERNEL__ test.
> > > >
> > > > Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
> > > >
> > > > ---
> > > >
> > > >   is there some value in allowing an effectively empty header file to
> > > > be exported to userspace?
> > > Not breaking the userspace? The file is included in non-__KERNEL__
> > > sections from byteorder/*_endian.h.
> >
> > ok ... and the value of including a completely empty header file is
> > ... ?
>
> No value, you should just move those includes into the __KERNEL__ part.

gotcha, that's what i'd concluded after your earlier post, i just
wasn't sure if there was something more subtle happening here.
revised patch coming soon.  thanks.

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/