[Fwd: Re: [alsa-devel] [regression] 2.6.25-rc4 snd-es18xx broken onAlpha]

From: Tyson Whitehead
Date: Tue Apr 01 2008 - 17:21:15 EST


Sorry. Bob was just saying this could be an important observation, but it didn't get to everyone as the CC list got shortened. Cheers! -Tyson

--- Begin Message --- Bob Tracy wrote:
Takashi Iwai wrote:
I vaguely remember about the patch... The patch below was on my local
tree but never pushed because of lack of testing. Does it work for
you?

---

diff -r 82e6201fc907 sound/isa/es18xx.c
--- a/sound/isa/es18xx.c Mon Mar 17 14:36:24 2008 +0100
+++ b/sound/isa/es18xx.c Mon Mar 17 17:32:59 2008 +0100
@@ -765,9 +765,10 @@ static irqreturn_t snd_es18xx_interrupt(
/* Read Interrupt status */
status = snd_es18xx_mixer_read(chip, 0x7f) >> 4;
}
-#if 0
- else {
- status = 0;
+
+#ifdef CONFIG_ALPHA
+ if (!(status & (AUDIO1_IRQ | AUDIO2_IRQ))) {
+ /* status = 0; */
if (inb(chip->port + 0x0C) & 0x01)
status |= AUDIO1_IRQ;
if (snd_es18xx_mixer_read(chip, 0x7A) & 0x80)
@@ -777,7 +778,6 @@ static irqreturn_t snd_es18xx_interrupt(
status |= HWV_IRQ;
}
#endif
-
/* Audio 1 & Audio 2 */
if (status & AUDIO2_IRQ) {
if (chip->active & DAC2)
--

The above patch doesn't make any difference for me as far as how the
ES1888 works. I get the same broken behavior as previously described.

I wonder if the difference between Bob and I (i.e., that I can get sound working with patching while he cannot) might be that all along I've been using CONFIG_ALPHA_GENERIC, while he has (possibly -- he will have to confirm this) been using CONFIG_ALPHA_MIATA.

As I mentioned in the email I just sent out, I just finished discovering that if I compile with CONFIG_ALPHA_MIATA, I can't get sound to work no matter what I do (patched or unpatched es18xx or sb8).

When I compile with CONFIG_ALPHA_GENERIC I can get sound working (modulo this new "Bad page state in process 'mpg321'" thing that started sometime after 2.6.14) with either the patched es18xx or standard sb8.

Cheers! -Tyson


--- End Message ---