Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac miniCore Duo

From: Tino Keitel
Date: Tue Apr 01 2008 - 14:37:09 EST


On Tue, Apr 01, 2008 at 12:52:13 +0200, Pavel Machek wrote:
> Hi!
>
> > > > [...]
> > > >
> > > > > Can you please try to boot with acpi_new_pts_ordering and retest?
> > > >
> > > > I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a),
> > > > without success. I still got the same hand at resume.
> > >
> > > I am having the hang on resume problem too (macbook pro), cf.
> > > http://bugzilla.kernel.org/show_bug.cgi?id=10319, 2.6.24 was fine.
> >
> > What about 2.6.25-rc5? Up to this, resume works for me. -rc6 is broken.
>
> Any chance to bisect?

git-bisect revealed this:

$ git bisect good
e82cc1288fa57857c6af8c57f3d07096d4bcd9d9 is first bad commit
commit e82cc1288fa57857c6af8c57f3d07096d4bcd9d9
Author: David Brownell <david-b@xxxxxxxxxxx>
Date: Fri Mar 7 13:49:42 2008 -0800

USB: fix ehci unlink regressions

The recent EHCI driver update to split the IAA watchdog timer out from
the other timers made several things work better, but not everything;
and it created a couple new issues in bugzilla. Ergo this patch:

- Handle a should-be-rare SMP race between the watchdog firing
and (very late) IAA interrupts;

- Remove a shouldn't-have-been-added WARN_ON() test;

- Guard against one observed OOPS;

- If this watchdog fires during clean HC shutdown, it should act
as a NOP instead of interfering with the shutdown sequence;

- Guard against silicon errata hypothesized by some vendors:
* IAA status latch broken, but IAAD cleared OK;
* IAAD wasn't cleared when IAA status got reported;

The WARN_ON is in bugzilla as 10168; the OOPS as 10078; these are
both regressions.

Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
Tested-by: Gordon Farquharson <gordonfarquharson@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

:040000 040000 ff621bb62396fdf71c7b97877ddbb8542f57b871
251bc90076ea0b3a14d0b88dd250581fa815b5de M drivers

For the linux-usb people: this commit breaks resume from suspend to RAM
on my Mac mini Core Duo. It worked with 2.6.24, 2.6.25-rc5, and was
broken since 2.6.25-rc6 (also with -rc7 and later). See
http://lkml.org/lkml/2008/3/20/23 for more information.

Regards,
Tino
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/