Re: [RFC PATCH 25/26] UBIFS: add debugging stuff

From: Pekka Enberg
Date: Tue Apr 01 2008 - 03:43:22 EST


Hi Artem,

On Tue, Apr 1, 2008 at 9:20 AM, Artem Bityutskiy <dedekind@xxxxxxxxx> wrote:
> Yeah, we will remove this later, keep it for now because it is very
> convenient. I guess you refer the /proc/slab_allocations feature.
> We found it less appropriate because it needs additional scripts to
> be run to detect leaks, while this simple just hack makes UBIFS print
> a message if there is a leak, which is just easier for us.

Why not fix it then to fit your needs? You do need leak detection
after you're in the mainline too, don't you?

On Tue, Apr 1, 2008 at 9:20 AM, Artem Bityutskiy <dedekind@xxxxxxxxx> wrote:
> That was introduced to test the UBIFS shrinker, and to make sure
> there are no races and everything works fine. Yes, will be removed
> later.

It sounds useful and necessary for developing in the mainline as well
so you might want to reconsider making it a standalone module in mm/.

Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/