Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups- formatting only
From: Jiri Slaby
Date: Sun Mar 23 2008 - 08:24:37 EST
On 03/23/2008 01:19 PM, David Miller wrote:
There are mountains of more useful stuff to be working on (much of it
automated, but unlike checkpatch work doesn't result in crap) rather
than 148 patches of checkpatch vomit.
Fixing sparse warnings properly fixes real issues, whereas fixing
checkpatch stuff creates garbage 9 times out of 10.
Yes, I agree with you in this.
What I don't agree with is that it's useless. It may help track down some issues
in yet prepared patch (it's checkpatch, not checkcode and it should be used in
that manner).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/