Re: [PATCH] CDROM: use kmalloced buffers instead of buffers onstack

[Cyrill Gorcunov]

[Thomas Bogendoerfer - Sun, Mar 23, 2008 at 12:15:32PM +0100]
| If cdrom commands are issued to a scsi drive in most cases the buffer
| will be filled via dma. This leads to bad stack corruption on non coherent
| platforms, because the buffers are neither cache line aligned nor is
| the size a multiple of the cache line size. Using kmalloced buffers
| avoids this.
| 
| Signed-off-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
| ---
| 
|  drivers/cdrom/cdrom.c |  274 ++++++++++++++++++++++++++++++++-----------------
|  1 files changed, 181 insertions(+), 93 deletions(-)
| 
[...]

Hi Thomas,

maybe would be better to use one memory pool instead?

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/