Re: [patch 4/4] x86: apic_is_clustered_box to indicate unsynchedTSC's on multiboard vSMP systems

From: Ingo Molnar
Date: Sat Mar 22 2008 - 16:03:31 EST



* Ravikiran G Thirumalai <kiran@xxxxxxxxxxxx> wrote:

> OK. Something like this?

yeah.

small nit:

> +int is_vsmp_box(void)
> +{
> + if (is_vsmp != -1)
> + return is_vsmp;
> + else {
> + printk("ScaleMP vSMPowered system detection called too early!\n");
> + return 0;
> + }
> }

since this is an "impossible" scenario, just stick in a WARN_ON_ONCE().

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/