[PATCH] Memory corruption in block2mtd.c

From: Ingo van Lil
Date: Thu Mar 20 2008 - 10:37:07 EST


Hello everybody,

the block2mtd driver (drivers/mtd/devices/block2mtd.c) will kfree an
on-stack pointer when handling an invalid argument line (e.g.
block2mtd=/dev/loop0,xxx).

The kfree was added some time ago when "name" was dynamically
allocated.

Cheers,
Ingo

Signed-off-by: Ingo van Lil <inguin@xxxxxx>
---

--- linux-2.6.23.1/drivers/mtd/devices/block2mtd.c.orig 2008-03-20 15:13:49.000000000 +0100
+++ linux-2.6.23.1/drivers/mtd/devices/block2mtd.c 2008-03-20 15:14:09.000000000 +0100
@@ -408,7 +408,6 @@
if (token[1]) {
ret = parse_num(&erase_size, token[1]);
if (ret) {
- kfree(name);
parse_err("illegal erase size");
}
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/