Re: [PATCH 0/79] smpboot integration

[Yinghai Lu]

On Wed, Mar 19, 2008 at 7:18 PM, Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:
> On Wed, Mar 19, 2008 at 10:35 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
>  >
>  >  * Glauber de Oliveira Costa <gcosta@xxxxxxxxxx> wrote:
>  >
>  >  > Testing and bisectability:
>  >  >
>  >  > The end result was tested in all my hardware (which includes qemu ;-).
>  >  > It does not mean it will boot _your_ hardware, but I did my best ;-)
>  >  >
>  >  > The tree at least compiles in more than 20 randconfigs (for each of
>  >  > x86_64 and i386) For i386, each of the subarchitectures was compiled
>  >  > at least once. (By compile, I obviously mean, every patch,
>  >  > individually)
>  >
>  >  very nice work! I'll pick it up - and i'm not too worried about
>  >  breakages because at 80 patches granularity any problem should be
>  >  identifiable in a very finegrained way.
>  >
>
>  it broke 4 sockets quad core above with 64 bit
>
>  Booting processor 11/15 ip 6000
>  Initializing CPU#11
>  masked ExtINT on CPU#11
>  Calibrating delay using timer specific routine.. 4589.46 BogoMIPS (lpj=9178934)
>  CPU: L1 I Cache: 64K (64 bytes/line), D cache 64K (64 bytes/line)
>  CPU: L2 Cache: 512K (64 bytes/line)
>  CPU 11/f -> Node 2
>  CPU: Physical Processor ID: 2
>  CPU: Processor Core ID: 3
>  CPU11: Quad-Core AMD Opteron(tm) Processor 8356 stepping 03
>  checking TSC synchronization [CPU#0 -> CPU#11]: passed.
>  Booting processor 12/16 ip 6000
>
>  looks like local apic id up 4 bit is masked out. so can not start 0x10
>  above any more.

in wakeup_secondary_via_INIT
before the patchsets
64 bit code:

        /*
         * Send IPI
         */
        apic_write(APIC_ICR, APIC_INT_LEVELTRIG | APIC_INT_ASSERT
                                | APIC_DM_INIT);


after patchset

        /* Boot on the stack */
        /* Kick the second */
        apic_write_around(APIC_ICR, APIC_DM_NMI | APIC_DEST_LOGICAL);

So that is wrong! esp for system has ext apic id that is has 8 bits
instead of 4 bits.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/