Re: [PATCH 0/4 v4] dma: dma_{un}map_{single|sg}_attrs() interface

[akepner]

On Thu, Mar 13, 2008 at 08:27:54AM -0700, Randy Dunlap wrote:

Thanks for looking at this. A new patchset is on the way.

> On Thu, 13 Mar 2008 01:41:06 -0700 Andrew Morton wrote:
> 
> > > +#ifdef ARCH_USES_DMA_ATTRS
> > 
> > There is no precedent for ARCH_USES_*.
> > 
> > There is a little bit of precedent for ARCH_HAVE_*
> > 
> > There is lots of precendence for ARCH_HAS_*.
> > 
> > We don't like ARCH_HAS_* anyway ;) What can we do to get rid of this? 
> > Ideally, make it available on all architectures at zero cost to those which
> > don't need it.  If that is impractical (why?) then it is preferable to do
> > this in Kconfig.
> 
> Sam has been pushing HAVE_* and even added that to
> Documentation/kbuild/kconfig-language.txt.

OK, changed it to CONFIG_HAVE_DMA_ATTRS.

> 
> > > +/*
> > > + * dma_set_attr - set a specific attribute
> > > + * may be called with a null attrs
> > > + */
> 
> Use kernel-doc notation?

Done.

-- 
Arthur

(503) 234 4671
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/