Re: [PATCH] thermal: fix Kconfig dependencies

From: Linus Torvalds
Date: Mon Mar 17 2008 - 22:25:41 EST




On Mon, 17 Mar 2008, Len Brown wrote:
>
> Similarly, ACPI_THERMAL should not depend on THERMAL,
> instead the code that registers with THERMAL should
> simply depend on if THERMAL is selected or not.
>
> Also, the "default y" should go.
>
> I'll tinker with this a bit after lunch.

Hmm.. It looks like the same commit that caused these Kconfig issues is
also the one that causes the problems with lmsensors (I didn't immediately
realize that it's the exact same commit).

I think that right now the right thing to do is to just revert it, since
apparently there won't be a released lmsensors version by the time 2.6.25
gets released that can handle the new sysfs layout, and that we should
give this some more time to be resolved.

So I'm inclined to revert commit 3152fb9f11cdd2fd8688c2c5cb805e5c09b53dd9
and plan on revisiting this for 2.6.26. I already got an ack for that from
Jean Delvare, but I thought I'd mention it in this thread too before I
actually do the final revert.

Any really strong objections?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/