Re: [PATCH] Do not allow setting of quota limits to too high values

From: Jan Kara
Date: Mon Mar 17 2008 - 09:11:49 EST


On Thu 13-03-08 13:03:55, Andrew Morton wrote:
>
> > Subject: [PATCH] Do not allow setting of quota limits to too high values
>
> Please put "quota:" at the start of the title to identify the subsystem. So,
>
> Subject: [PATCH] quota: do not allow setting of quota limits to too high values
>
> would have suited. Thanks.
Sorry for that. I've realized I forgot to add "quota:" only after I've sent
the email and figured out it's not worth resending it with "quota:" added.

> On Wed, 12 Mar 2008 18:22:55 +0100
> Jan Kara <jack@xxxxxxx> wrote:
>
> > From: Andrew Perepechko <andrew.perepechko@xxxxxxx>
> >
> > We should check whether quota limits set via Q_SETQUOTA are not exceeding
> > limits which quota format is able to handle.
> >
> > Signed-off-by: Andrew Perepechko <andrew.perepechko@xxxxxxx>
> > Signed-off-by: Jan Kara <jack@xxxxxxx>
> >
> > ---
> > Andrew, would you please queue it up for inclusion? Thanks.
>
> For 2.6.26, I assume? I am not able to determine the seriousness of this
> problem from the changelog nor from the patch itself.
Not really serious. Nobody complained so far (i.e., for the time quota
exists) and the limits will just wrap when you try to set them over 4TB
now. So the patch can wait...

Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/