RE: [PATCH, RFC] Create 'slot' sysfs attribute in/sys/devices/system/cpu/cpuN/topology/
From: Luck, Tony
Date: Wed Mar 12 2008 - 17:47:20 EST
> include/asm-x86/cpu.h | 1 +
I assume this slipped in accidentally (though it would
eventually be needed for an x86 version of this patch).
> +#ifdef topology_slot
> +define_id_show_func(slot);
> +define_one_ro(slot);
> +#define ref_slot_attr &attr_slot.attr,
> +#else
> +#define ref_slot_attr
> +#endif
This is a bit ugly ... I don't see how to make it better (but
I'm sure that akpm will say "You could just ...", and then
I'll wonder why I didn't think of that).
> +EXPORT_SYMBOL(arch_set_topology_slot);
As the author you get to choose the license ... but there is
strong movement to make new exported symbols GPL only.
When I apply this patch and run it on my tiger, I see a slew
of
ACPI: Invalid PBLK length [0]
messages on my console during boot and the see
$ cat /sys/devices/system/cpu/cpu0/topology/slot
-1
So I guess that the _SUN method isn't there on my machine.
-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/